Skip to content

fix(Database): escape table string in SQLSRV Builder::_upsertBatch() Object_ID - #10734

Open
gr8man wants to merge 1 commit into
codeigniter4:developfrom
gr8man:fix/sqlsrv-builder-upsert-batch-escape
Open

gr8man wants to merge 1 commit into
codeigniter4:developfrom
gr8man:fix/sqlsrv-builder-upsert-batch-escape

Conversation

@gr8man

@gr8man gr8man commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Description
SQLSRV\Builder::_upsertBatch() concatenated the table name string directly into Object_ID('" . $table . "') without escaping, resulting in syntax errors on table names with quotes or special characters. It now properly escapes the table name using $this->db->escape($table).

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@carson-codeigniter4 carson-codeigniter4 Bot added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant