Skip to content

fix(Database): escape table and column names in SQLSRV Forge default constraint lookups - #10736

Open
gr8man wants to merge 1 commit into
codeigniter4:developfrom
gr8man:fix/sqlsrv-forge-alter-table-escape
Open

gr8man wants to merge 1 commit into
codeigniter4:developfrom
gr8man:fix/sqlsrv-forge-alter-table-escape

Conversation

@gr8man

@gr8man gr8man commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Description
SQLSRV\Forge::_alterTable() interpolated table and column names directly into default constraint lookup queries without escaping, which caused syntax errors when names contained quotes or special characters. This change properly escapes them using $this->db->escape().

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@carson-codeigniter4 carson-codeigniter4 Bot added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant