Repository navigation
fix: render Unicode block elements without glyph seams - #212
Open
davidbrochart wants to merge 1 commit into
Open
davidbrochart wants to merge 1 commit into
davidbrochart wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjacent Unicode block glyphs can show seams when drawn with
fillText(), depending on font metrics and display scaling. This is visible in the solid blue parts of the LazyVim dashboard logo, even after aligning cell backgrounds.Render solid Unicode Block Elements as geometric rectangles with shared physical-pixel boundaries: full blocks, fractional horizontal/vertical blocks, and quadrant combinations. Preserve the existing foreground selection, inverse, faint, cursor-color, and invisible handling. Ordinary text, grapheme clusters, shaded blocks, and box-drawing glyphs retain font rendering.
This PR is independent of #211: that change fixes cell backgrounds; this fixes block-character foregrounds. It does not attempt to fix seams in box-drawing font glyphs.
Validation: