Repository navigation
fix(widget): keep focus in the popup on the consent notice and menu choices - #625
Merged
Merged
Conversation
anurag629
approved these changes
Nov 19, 2026
anurag629
left a comment
Member
There was a problem hiding this comment.
Thanks @bhushan4work. Opening a popup that waits for consent now focuses the notice (it gets tabindex="-1"), so a screen reader reads it and Escape closes the chat, while an inline chat leaves focus alone. Choosing a menu item puts focus back on More options, the same as Escape. The unit tests check activeElement for both, and S17 now checks focus instead of setting it. I updated your branch with dev. All checks pass, including e2e.
Member
|
Merged, thanks @bhushan4work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fix the two places focus escaped the popup dialog.
waitForConsent: true, opening the popup now focuses the consent notice, which getstabindex="-1", so it is announced and Escape closes the chat. Inline mode keeps its existing behavior and does not take focus.Added unit tests for both focus paths, updated the S17 and header menu e2e tests to assert focus, and added a patch changeset for
@chatcops/widget.Closes #608
How I tested this
Ran
pnpm test:coverage,pnpm lint,pnpm size, andpnpm e2e; all pass.AI assistance
None
Checklist
devpnpm -r build,pnpm testandpnpm -r typecheckpass locallypnpm changeset) if this changescore,widgetorserverpnpm apirun andapi/committed if an exported type or option changed