Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chatcops/react(#583) still has"private": true, sochangeset publishskips it and the release (#627) wouldn't publish it, while the docs page it adds tells people to install it. This takes the flag off, as #558 did for cli, ingest and the stores, and adds thepublishConfigevery other package has. It also adds a README, since it's the only package without one and npm shows the README as the package page.The version PR will publish it as 0.2.0 (0.1.0 plus the minor changeset from #583).
This stays a draft until trusted publishing is set up for
@chatcops/reacton npm. The package doesn't exist there yet, and the release workflow publishes through OIDC, which can't create a new package.How I tested this
pnpm pack: the tarball hasREADME.md,dist/andpackage.json, with noprivateflag and the widget peer as^1.1.1(workspace:^rewritten).pnpm --filter @chatcops/react test: 22 passed.typecheckpasses.