Repository navigation
feat(templates): add Two Takes quote template (quote-two-takes) - #426
Merged
anurag629 merged 2 commits intoNov 19, 2026
Merged
Conversation
8 tasks
anurag629
requested changes
Nov 17, 2026
anurag629
left a comment
Member
There was a problem hiding this comment.
Hey @Saifjafri212213, nice work, the two columns stay the same width in all four previews, both quotes share one size, and the long case truncates the quotes, bylines and site name without pushing anything off the card. The chip and labels read fine on the light background too.
A few things before I can merge:
- A blank label falls back to "Yes"/"No" (
src/templates/quote/two-takes.ts:101and:102), so the empty preview still shows both pills. #411 asks for a blank label to leave no gap, so please drop the fallback and skip the pill when the label is blank, the way the byline is skipped at :176, and add a test for it. - The quotes come out at 30px in the defaults, because the longer one is 61 characters and just misses the 60 step at :91. That leaves close to 300px of empty space between each quote and its byline. #411 asks for the quote in large type and each column has the room, so please move the steps up, something like 40px up to 70 characters, then 34, 28 and 24px for the 220 cap.
Everything else looks good.
Collaborator
Author
|
Thanks for the review @anurag629! I've addressed both points in b9a0acf:
All unit tests (14/14), full test suite (2128/2128), preview renders, and type checks pass cleanly. |
Saifjafri212213
force-pushed
the
fix/411-quote-two-takes
branch
from
November 18, 2026 14:44
b9a0acf to
9718f3a
Compare
anurag629
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the Two Takes quote template (
quote-two-takes) in the Quote category, as requested in #411.How it works:
src/templates/quote/two-takes.ts(id: 'quote-two-takes'):autoFontSize()and single-line ellipsis truncationaccentInk/ accent color pill and right column uses muted text toneautoFontSize()so columns stay balancedisLightColor()andmixColors()tests/templates/two-takes.test.ts(12 tests) covering registration, defaults, fallback quotes, omitted fields, quote truncation, synchronized font sizing, title scaling, light background readability, and "vs" chip rendering.src/templates/quote/index.tsand registered in the quote block ofsrc/templates/registry.ts.Closes #411
How I Tested This
npx vitest run tests/templates/two-takes.test.ts→ 12/12 tests passednpm test→ 110 test files, 2126/2126 tests passedPREVIEW_FILES=src/templates/quote/two-takes.ts npx vitest run tests/templates/previews.test.ts→ rendered all 4 variants (defaults, empty, light, long)npx tsc --noEmit→ 0 errorsAI Assistance
Antigravity for layout structure, Satori element hierarchy, and unit test coverage.
Type of Change
Checklist
devnpm run check/tsc --noEmitpassesnpm run testpasses