Repository navigation
feat(templates): add Mailbag newsletter template (newsletter-mailbag) - #428
Open
Saifjafri212213 wants to merge 1 commit into
Open
Saifjafri212213 wants to merge 1 commit into
Saifjafri212213 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the Mailbag newsletter template (
newsletter-mailbag) in the Newsletter category, as requested in #410.How it works:
src/templates/newsletter/mailbag.ts(id: 'newsletter-mailbag'):siteNameorissueleaves no gap in the header, and an empty header row is omitted entirelyisLightColor()andmixColors()so the pill, Q circles, and askers stay readabletests/templates/mailbag.test.ts(10 tests) covering registration, defaults, dropped question rows, all blank questions, blank asker width expansion, title auto-sizing, question and asker truncation, empty header fields, and light background readability.src/templates/newsletter/index.tsand registered in the newsletter block ofsrc/templates/registry.ts.Closes #410
How I Tested This
npx vitest run tests/templates/mailbag.test.ts→ 10/10 tests passednpm test→ 112 test files, 2152/2152 tests passedPREVIEW_FILES=src/templates/newsletter/mailbag.ts npx vitest run tests/templates/previews.test.ts→ rendered all 4 variants (defaults, empty, light, long)npx tsc --noEmit→ 0 errorsAI Assistance
Antigravity for layout structure, Satori element hierarchy, and unit test coverage.
Type of Change
Checklist
devnpm run check/tsc --noEmitpassesnpm run testpasses