Repository navigation
List the deploy hooks the plugin registers in the README - #14
Merged
Merged
Conversation
La section Usage disait que le plugin lance solid_queue:restart après le déploiement. register_hooks enregistre en fait quiet après deploy:starting, stop après deploy:updated, start après deploy:published et restart seulement après deploy:failed. quiet envoie SIGTERM, auquel Solid Queue 1.7.2 répond par un arrêt propre (supervisor/signals.rb). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Usage section of the README says the plugin runs
solid_queue:restartafter deploy.register_hooks(lib/capistrano/solid_queue.rb) registers something else:solid_queue:quietafterdeploy:starting;solid_queue:stopafterdeploy:updated;solid_queue:startafterdeploy:published;solid_queue:restartonly afterdeploy:failed.Changes
The Usage section lists these four hooks and what each task does.
solid_queue:quietrunssystemctl kill -s SIGTERM, and Solid Queue 1.7.2 answersTERMwith a graceful shutdown (lib/solid_queue/supervisor/signals.rb:stopthenterminate_gracefully).The line linking to
#register_hooksstays as is, so this doesn't conflict with the Configuration section that #13 adds right after it. The CHANGELOG entry will come with the 0.2.0 release commit, since #13 also adds entries to the Unreleased section.Tests
No automated test: this is documentation. Checked against
register_hooks, the tasks inlib/capistrano/tasks/solid_queue.rakeand the Solid Queue 1.7.2 source.git merge-treeshows no conflict with #13.🤖 Generated with Claude Code