Skip to content

List the deploy hooks the plugin registers in the README - #14

Merged
burisu merged 1 commit into
mainfrom
readme-usage-hooks
Nov 9, 2026
Merged

burisu merged 1 commit into
mainfrom
readme-usage-hooks

Conversation

@burisu

@burisu burisu commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Problem

The Usage section of the README says the plugin runs solid_queue:restart after deploy. register_hooks (lib/capistrano/solid_queue.rb) registers something else:

  • solid_queue:quiet after deploy:starting;
  • solid_queue:stop after deploy:updated;
  • solid_queue:start after deploy:published;
  • solid_queue:restart only after deploy:failed.

Changes

The Usage section lists these four hooks and what each task does. solid_queue:quiet runs systemctl kill -s SIGTERM, and Solid Queue 1.7.2 answers TERM with a graceful shutdown (lib/solid_queue/supervisor/signals.rb: stop then terminate_gracefully).

The line linking to #register_hooks stays as is, so this doesn't conflict with the Configuration section that #13 adds right after it. The CHANGELOG entry will come with the 0.2.0 release commit, since #13 also adds entries to the Unreleased section.

Tests

No automated test: this is documentation. Checked against register_hooks, the tasks in lib/capistrano/tasks/solid_queue.rake and the Solid Queue 1.7.2 source. git merge-tree shows no conflict with #13.

🤖 Generated with Claude Code

La section Usage disait que le plugin lance solid_queue:restart après
le déploiement. register_hooks enregistre en fait quiet après
deploy:starting, stop après deploy:updated, start après
deploy:published et restart seulement après deploy:failed. quiet envoie
SIGTERM, auquel Solid Queue 1.7.2 répond par un arrêt propre
(supervisor/signals.rb).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@burisu
burisu marked this pull request as ready for review November 9, 2026 09:16
@burisu
burisu merged commit baca751 into main Nov 9, 2026
5 checks passed
@burisu
burisu deleted the readme-usage-hooks branch November 9, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant