Repository navigation
fix(dictation): CLI executable builds again with local dictation - #48
Closed
collissimo wants to merge 1 commit into
Closed
collissimo wants to merge 1 commit into
collissimo wants to merge 1 commit into
Conversation
The single-executable build refuses package imports it cannot resolve, and local dictation imported koffi and transcribe-cpp that way, so the fork release failed once it started building the CLI archive. Both now load from disk through require, as node-pty does. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Owner
Author
|
Superseded by #47, which fixed the same imports and is already merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork release has failed since #46 added the CLI archive:
build-exerejects package imports a single-executable cannot resolve, and local dictation importedkoffiandtranscribe-cppwithimport().Both now load from disk through
createRequire, the way node-pty and the other native packages do.transcribe-cpponly exports an import entry, so itsdist/index.jsis required by path, asspeech/native.tsdoes.Checked:
node apps/server/scripts/cli.ts build-exepasses locally (it failed before), and both packages load through the new path in Node. Not checked: dictation on Windows and in the desktop app.check:changedfails only inreact compileronDictationHistoryDialog.tsx, which this PR does not touch.Claude Fable 5.2, Claude Code.
🤖 Generated with Claude Code