Repository navigation
chore(deps): bump brace-expansion override to 1.1.21 - #48
Conversation
Close Dependabot alert #77 (GHSA-q2hr-2g5m-vwhr) by raising the existing 1.x override so every brace-expansion 1.x copy is patched.
|
comphy-bot review status for Review completed for this exact pull request head. |
comphy-bot
left a comment
There was a problem hiding this comment.
Review: brace-expansion security override
Reviewed the exact head d5ef177: +4/-4 across package.json and package-lock.json.
The override remains an exact pin on the existing 1.x line, and the lockfile version and npm registry URL move consistently to 1.1.21 with an updated integrity value. No unrelated dependencies or executable application logic change. No P0/P1 findings identified.
Verification: the exact-head build check succeeded; the shared conflict-marker and trailing-whitespace checks passed. Deployment was skipped. Peer review threads contain no outstanding findings. No PR code or install/test scripts were executed during this review; the integrity digest was inspected in the diff, not independently verified against the registry.
Description
Dependabot alert #77 flags transitive
brace-expansion1.x below 1.1.21 (GHSA-q2hr-2g5m-vwhr, quadratic-time expansion CPU DoS). The existing npm override was pinned at 1.1.18, so the lockfile stayed on a vulnerable 1.x release.This PR raises that override to 1.1.21 and refreshes the lockfile entry. No major-version bumps and no unrelated package updates.
Type of Change
Changes Made
overrides.brace-expansion: 1.1.18 → 1.1.21 (stays on the 1.x line)package-lock.json:brace-expansion1.1.18 → 1.1.21 (resolved URL + integrity)Testing Done
npm cinpm ls brace-expansion— only 1.1.21 (no 1.x < 1.1.21)npm test(11/11 passed)npm run lint(js/css/md clean)bundle exec jekyll serve(Ruby not available in this environment)Related Issues
Addresses Dependabot alert #77 (
brace-expansion< 1.1.21 / GHSA-q2hr-2g5m-vwhr).Checklist
Additional Notes
Review should focus on the override pin and lockfile integrity hash for
brace-expansion1.1.21.MERGE_READY — checks green, 0 unresolved review threads. Not merging per task stop.
Summary by CodeRabbit