[cpyrt] Exempt T* const& from the mutable pointer-reference ban - #92
Open
aaronj0 wants to merge 1 commit into
Open
[cpyrt] Exempt T* const& from the mutable pointer-reference ban#92aaronj0 wants to merge 1 commit into
aaronj0 wants to merge 1 commit into
Conversation
aaronj0
force-pushed
the
tptr-const-ref-converter
branch
from
September 8, 2026 06:53
6b53387 to
2881ffa
Compare
TypeManip::compound() strips const, so T*& and T* const& both reach the converter factory as "*&" and were rejected alike. The callee cannot rebind the pointer through a T* const&, which is the ban's sole rationale; ask the type via a new interop::IsMutablePtrRefType (the referenced type is a pointer and not const-qualified) and route const ones to the regular instance-pointer converters. In the string-based factory a name that resolves to no type keeps the ban.
aaronj0
force-pushed
the
tptr-const-ref-converter
branch
from
September 8, 2026 08:56
2881ffa to
cde66df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
interop::IsMutablePtrRefType: the string-based check from the ROOT migration branch was adapted to be more robust with CppInterOp.TypeManip::compound() strips const allowing both T*& and T* const& reach the converter factory as "*&" and were rejected alike. The callee cannot rebind the pointer through a
T* const&, which is the ban's sole rationale; ask the type via a new interop::IsMutablePtrRefType (the referenced type is a pointer and not const-qualified) and route const ones to the regular instance-pointer converters. In the string-based factory a name that resolves to no type keeps the ban.