[FTAB-214] Update the lifecycle example to use new StatementHandle and statement lifecycle methods - #25
Open
Mika Naylor (autophagy) wants to merge 1 commit into
Open
[FTAB-214] Update the lifecycle example to use new StatementHandle and statement lifecycle methods#25Mika Naylor (autophagy) wants to merge 1 commit into
Mika Naylor (autophagy) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Mika Naylor (autophagy)
September 11, 2026 16:38
View session
airlock-confluentinc
Bot
force-pushed
the
FTAB-214
branch
from
September 11, 2026 16:39
3f86700 to
be58a2d
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The dependency pin and lifecycle API issues must be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates lifecycle examples and documentation for StatementHandle, adds statement management commands and warning inspection, and bumps confluent-pyflink to 2.3.3.
Changes:
- Adds stop, resume, and delete CLI operations.
- Restores
with_all_columns()usage. - Documents statement lifecycle APIs and warnings.
File summaries
| File | Summary | Final review comments |
|---|---|---|
README.md |
Documents StatementHandle usage. |
Nit (1 vote): Inspect warnings before deleting the statement. |
pyproject.toml |
Raises the PyFlink dependency version. | Critical (3 votes): Update requirements.txt from 2.3.2 to 2.3.3. |
examples/example_08_integration_and_deployment.py |
Adds CLI lifecycle management and warning inspection. | Moderate (2 votes): Use StatementHandle.stop() instead of ConfluentTools.stop_statement. |
examples/example_03_transforming_tables.py |
Restores with_all_columns() usage. |
No final review comments. |
Review details
Suppressed comments (1)
README.md:482
- The example deletes this statement immediately before calling
get_warnings()on the same handle. Since warning inspection is a statement API lookup, deleting the statement can make this request fail (or return no warnings); show the warnings beforedelete(), or use a separate live statement handle for this example.
for warning in handle.get_warnings():
print(warning.severity.value, warning.reason, warning.message)
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…d statement lifecycle methods
airlock-confluentinc
Bot
force-pushed
the
FTAB-214
branch
from
September 11, 2026 16:46
be58a2d to
8c8d678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does several things:
with_all_columnsexpression removed in the migration over).StatementHandlestatement lifecycle methods over using theConfluentToolsstatement lifecycle methods.StatementHandle, as well adding argument parsing and lifecycle operations so users canuv run examples/example_08_integration_and_deployment.py [stop/resume/delete] vendors-per-brand-...statements. Also adds a section for inspecting the statement warnings.Also tried to use fstrings around rather than the
%string formatting for better legibility