Skip to content

Update docker.io/library/golang Docker tag to v1.26.8 (main) #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
red-hat-konflux wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Update docker.io/library/golang Docker tag to v1.26.8 (main) #3372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

## Build

FROM docker.io/library/golang:1.26.7@sha256:e30143be198ab04cf7ba25fba83ab3a692ca584c994aad0bf131fa0eb32dd8c1 AS build
FROM docker.io/library/golang:1.26.8@sha256:3c3e25a4da13fd0478eed2df1eb35a0e667094a7124d3993a6a1d30f71c17e79 AS build

Check failure on line 19 in Dockerfile

View workflow job for this annotation

GitHub Actions / Test 

Containerfile version incompatible, saw 1.26.8, running with version: 1.26.7

@fullsend-ai-review fullsend-ai-review Bot Sep 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] protected-path

PR modifies Dockerfile, which is on the repository protected-paths list. The change is a Renovate patch bump of the docker.io/library/golang base image from 1.26.7 (sha256:e30143be...) to 1.26.8 (sha256:3c3e25a4...) authored by the red-hat-konflux bot, with a clear description of what and why. Human approval is always required for protected-path changes, regardless of automation source or apparent triviality.

Suggested fix: Human reviewer should confirm the new tag/digest pair (docker.io/library/golang:1.26.8@sha256:3c3e25a4da13fd0478eed2df1eb35a0e667094a7124d3993a6a1d30f71c17e79) corresponds to a legitimate upstream library/golang image before merging.

@fullsend-ai-review fullsend-ai-review Bot Sep 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] protected-path

PR modifies Dockerfile, which is in the repository's protected-paths list. The description explains the change (MintMaker/Renovate automated patch bump of the golang stage base image from 1.26.7 to 1.26.8, with the corresponding sha256 digest updated in the same line), providing sufficient rationale. Human approval is always required for protected-path changes, regardless of automation source.

@fullsend-ai-review fullsend-ai-review Bot Sep 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] protected-path

This PR modifies Dockerfile, which is in the repository's protected-paths list (governance/infrastructure). The PR body provides sufficient context (Renovate/Mintmaker automated patch bump of docker.io/library/golang from 1.26.7 to 1.26.8, with a matching sha256 digest re-pin), and the repo's renovate.json authorizes automated Docker tag updates for this class of change. Human approval is nonetheless always required for protected-path changes, regardless of context.

@fullsend-ai-review fullsend-ai-review Bot Sep 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] protected-path

The PR modifies Dockerfile, which is included in the repository protected-path list (REVIEW_PROTECTED_PATHS). Governance/infrastructure files always require human approval, regardless of context. The change itself is a mechanical Renovate patch tag bump (golang:1.26.7 -> golang:1.26.8) with digest re-pinned, and the repo has renovate.json extending the org-level Renovate config, so authorization for the change pattern is present; however, protected-path modifications must still be human-approved.

Suggested fix: No code change required. Confirm human review before merge.

@fullsend-ai-review fullsend-ai-review Bot Sep 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] protected-path

PR modifies Dockerfile, a protected path. The change is a Renovate/Mintmaker-authored patch-level golang base image bump (1.26.7 -> 1.26.8) with the sha256 digest also updated. Authorization for this pattern is documented in the repository's renovate.json (extending github>conforma/.github//config/renovate/renovate.json), and the PR body explains the rationale. Human approval is still required for protected-path changes.

Suggested fix: Verify the new tag+digest match the intended upstream golang:1.26.8 image and merge manually (or via the configured automerge policy).


@fullsend-ai-review fullsend-ai-review Bot Aug 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] metadata inconsistency

The PR title says 'Update ... to v1.26.4' but the actual diff bumps the image from golang:1.26.3 to golang:1.26.5, skipping 1.26.4 entirely. The PR body mentions '1.26.3 to 1.26.4, Pending: 1.26.5', confirming the title is stale relative to the committed change. This is a cosmetic mismatch typical of Renovate bot rebases but could cause confusion when triaging or auditing dependency updates.

@fullsend-ai-review fullsend-ai-review Bot Aug 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] metadata inconsistency

The PR title references v1.26.4, but the actual diff updates the golang image from 1.26.3 to 1.26.5. The PR body lists the change as 1.26.3 → 1.26.4 with 1.26.5 as pending, yet the committed code already uses 1.26.5. This is likely due to Renovate rebasing onto a newer version after the PR was initially created.

@fullsend-ai-review fullsend-ai-review Bot Aug 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] protected-path

This PR modifies Dockerfile, which is a protected governance/infrastructure path. The PR has no linked issue providing authorization for the change. Human approval is required for all changes to protected paths.

Suggested fix: Ensure a human reviewer approves changes to the Dockerfile. Consider linking to an issue that authorizes this infrastructure change.

ARG TARGETOS
ARG TARGETARCH
Expand Down
Loading