Conversation
… column Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013L98ArhvRJ1p7riCvTRXBf
…not its id The related selection of a has-one / has-many column always holds the relation's id, and the header filter's search put containsCI on it. The engine offers containsCI on String columns only, so it rejected every search and the panel showed no rows. Fixes #138 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013L98ArhvRJ1p7riCvTRXBf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #138.
Problem
The search box in a
DataGridHasOneColumn/DataGridHasManyColumnheader filter searched every scalar of the column's related selection. That selection always holds the relation'sid, so typing „Al" sent:{ "or": [{ "id": { "containsCI": "Al" } }, { "name": { "containsCI": "Al" } }] }A Contember engine offers
containsCIon String columns only. It rejected the query, and the panel showed no rows for any search.Fix
extractScalarFieldNamesin both column files leavesidout of the searched fields. The search now sends{ name: { containsCI: "Al" } }.Tests
tests/react/dataview/relationFilterSearchFields.test.tsx(first commit) types into the header filter of a has-one and a has-many column and checks the options query. It fails onmainand passes with the fix.bun run typecheck,bun run lint,bun run test(2200 pass, 0 fail).A more complete fix would keep only fields whose
SchemaRegistry.getColumnTypeisString, so that a cell rendering a number, date or enum does not break the search either. It needs a schema with column types, whichtestSchemadoes not carry, so it is left out here.🤖 Generated with Claude Code
https://claude.ai/code/session_013L98ArhvRJ1p7riCvTRXBf