Repository navigation
Run every documented check in CI - #290
Merged
Merged
Conversation
The workflow ran the format, clippy, and test commands but not the docs build, the declared minimum Rust version, or the `no_std` build, so a regression in any of them reached `main` unnoticed. It also installed nextest from a third-party host and a floating nightly for rustfmt. The new jobs run the commands the README now lists, nextest comes from crates.io at a pinned version, and rustfmt runs on a pinned nightly. The stray `libempty_match.rlib` is gone and `.gitignore` covers build artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
[deepseek-v4.1-flash] CI now runs every check the README's Development section lists. Before this PR the workflow ran rustfmt, clippy, and nextest only, so a docs regression, a break on the declared Rust 1.89, or a
no_stdbreak reachedmainunnoticed.Approach
Three jobs are new:
docbuilds the docs withRUSTDOCFLAGS="-D warnings",msrvchecks the workspace on 1.89, andno_stdcheckscgp-no-std-testsforx86_64-unknown-nonewith and without--features alloc. The README lists their commands beside the existing ones, so a contributor can reproduce any job locally.Two installs change. rustfmt runs on
nightly-2026-11-05instead of the floatingnightly, because.rustfmt.tomlsets unstable options and a floating channel can reformat the tree without a commit. nextest comes from crates.io at a pinned 0.9.151 throughcargo install --locked, into its own root so the cache holds nothing else, replacing the tarball from a third-party host.Impact
The
no_stdjob installsx86_64-unknown-noneitself, and every job sets a timeout. The workflow keepspermissions: contents: readand its concurrency group.The stray
libempty_match.rlibis removed, and.gitignorenow covers*.rliband*.rmetaas well as/target.