Conversation
Action, MultiAction, ToolbarButton, Export and filter SubmitButton passed an empty text to the translator, so icon-only buttons produced a missing-translation entry for '' on every render. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012jmXrhsCDpW1PebtBnDxhy
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1314 +/- ##
==========================================
+ Coverage 54.78% 55.65% +0.87%
==========================================
Files 65 65
Lines 3019 3022 +3
==========================================
+ Hits 1654 1682 +28
+ Misses 1365 1340 -25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012jmXrhsCDpW1PebtBnDxhy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #909.
Problem: an icon-only action (empty name) still called
translate('')on every row. That filled translator logs with missing''keys.Fix: skip the text when it is
''. This applies to Action, MultiAction, ToolbarButton, Export and Filter SubmitButton. The rendered HTML is the same.'0'is still rendered.Tested (locally):
Note: Export still translates its
titlewhen it is''. I did not change that, because it would change the output.🤖 Generated with Claude Code
https://claude.ai/code/session_012jmXrhsCDpW1PebtBnDxhy
Generated by Claude Code