Repository navigation
Treat Identity member 404 as not found - #7
Merged
Merged
Conversation
Callers such as Tokyo already treat a nil member as \"not found\"; avoid raising Faraday::ResourceNotFound for missing members. Bump to 0.1.5.
- Ruby 3.4+ (local/CI 4.0), refresh GitHub Actions and commit Gemfile.lock - Require vertebrae >= 2.0; replace juwelier with a hand-maintained gemspec - Handle 404 via Vertebrae::ResponseError and Faraday::ResourceNotFound - JSON.generate for request bodies; fix WebMock stubs for Vertebrae paths
ehimen-io
changed the title
ehimen-io
marked this pull request as ready for review
October 20, 2026 13:27
lavaturtle
requested changes
Oct 20, 2026
lavaturtle
left a comment
lavaturtle
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing all this modernization while you're in here! With a few tweaks I think this is great.
- Bump to 1.0.0; drop committed Gemfile.lock - Update gemspec metadata, exclude spec/, use vertebrae ~> 2.0 - Revert to params.to_json; rescue only Faraday::ResourceNotFound
lavaturtle
approved these changes
Oct 20, 2026
Co-authored-by: Grey Moore <grey@controlshiftlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Identity has no member for a lookup, `member#details` returns nil instead of raising.
Also modernizes the repo: Ruby 3.4+, current CI, and Vertebrae 2 (drops juwelier).
Test plan