Repository navigation
feat(web): back web_search/web_fetch with selected web plugin provider - #1327
Closed
TheGreatAxios wants to merge 3 commits into
Closed
TheGreatAxios wants to merge 3 commits into
TheGreatAxios wants to merge 3 commits into
Conversation
resolveWebProviderFromPlugins no longer ends at brand display: the active WebProvider is injected into createWebSearchTool/createWebFetchTool via createAgentToolset({ webProvider }). With no plugin selected the always-on core backends (keyless Exa/Parallel MCP search, native SSRF-guarded fetch) serve the tools unchanged. Docs (PLUGINS, ARCHITECTURE, IMPLEMENTATION) agree.
- Strip URL.hostname brackets before isIP so [::1] classifies as private directly instead of failing closed via DNS. - Decode hex ::ffff: tails (WHATWG URL normalizes ::ffff:127.0.0.1 to ::ffff:7f00:1) for the mapped-IPv4 private check. - Permanent test: bracketed loopback/mapped refuse as private, not DNS error. - Document that WebProvider.fetch is opaque: pre-checked URL in, server-side redirects are provider trust (no per-hop re-check, unlike core runWebFetch).
Collaborator
Author
|
Closing as stale — superseded by ongoing work. Reopen if still wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-9885.
Decision: wired (not deleted). resolveWebProviderFromPlugins used to end at setActiveWebProviderBrand with the WebProvider discarded; the active provider is now injected into createWebSearchTool/createWebFetchTool via createAgentToolset({ webProvider }). No web plugin selected keeps the always-on core backends (keyless Exa/Parallel MCP search, native SSRF-guarded fetch) unchanged.
Tests: src/web/web-provider-tools.test.ts — provider backs both tools plus a toolset-level run through dynamicRunner. Targeted suites (src/web, web-search, web-fetch, loader, tool-plugins, web-brand): 63 pass. typecheck + lint clean.