Repository navigation
feat(plugins): add in-process intercept hooks after secret-guard and permission gate - #1330
Closed
TheGreatAxios wants to merge 2 commits into
Closed
TheGreatAxios wants to merge 2 commits into
TheGreatAxios wants to merge 2 commits into
Conversation
…mission gate beforeModel hooks could rewrite an allowed call into a secret-guard/permission-denied shape (read -> .env, bash -> rm -rf /) that executed without re-validation. The hook middleware now re-runs a hook-replaced call through secret-guard plus the stack permission gate before execution; mutated-to-denied answers with the denial directly (never executes, never reaches afterTool). Unmutated calls are not re-evaluated, so no double-prompt. Adds full-stack regression tests.
Collaborator
Author
|
Closing as stale — superseded by ongoing work. Reopen if still wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun test src/plugins/intercept-hooks.test.tspasses (14 tests: inject, skip, replace, failure-is-logged, gate-still-enforced)bun run checkpasses (lint, typecheck, full suite: 8349 pass, 0 fail)Fixes CL-9888
Related to CL-5198