Skip to content

Ollama SystemOne evaluator shim - #1336

Closed
TheGreatAxios wants to merge 2 commits into
mainfrom
cl-9925-ollama-decide
Closed

TheGreatAxios wants to merge 2 commits into
mainfrom
cl-9925-ollama-decide

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Fixes CL-9925.

Standalone evaluator seam for local SystemOne decisions via Ollama: createOllamaSystemOneEvaluator({ rootURL, model, fetchFn? }) POSTs { model, state, questions } to {rootURL}/v1/systemone and maps timeout, non-2xx, connection-refused, and invalid answers (unknown choice, out-of-range score, out-of-range noul) to fallback: true.

Notes for review:

  • The decide tool (CL-9883, PR feat(tools): decide tool via Jev #1331, src/tools/decide.ts) is not merged, so validation logic is duplicated minimally in src/tools/decide-ollama.ts with a pointer comment; the decide tool can adopt this factory as its evaluate dep without changing its TYPESAFE default.
  • No chat-adapter reuse: the local clef-flash model rejects /api/chat and /api/generate; only POST /v1/systemone is used. One call, one backend; TYPESAFE stays the decide default.
  • Package note: package.json has no reference to @corbits/ollama-adapter (verified via grep), so no doc updates were needed. That adapter is chat-only and unrelated to this SystemOne path.

Verification:

  • bun test src/tools/decide-ollama.test.ts: 6 pass, 0 fail (5 stub-fetch: success, unknown-choice->fallback, timeout->fallback, http-error->fallback, refused->fallback; 1 live opt-in).
  • bun run check (lint, typecheck, dead-exports, build, guarded suite): 8341 pass, 0 fail across 539 files.
  • Live Ollama (localhost:11434, clef-flash): HTTP 200, ok=true, latency 227ms warm (1.9s cold first call).

@linear-code

linear-code Bot commented Oct 5, 2026

Copy link
Copy Markdown

CL-9925

@TheGreatAxios

TheGreatAxios commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator Author

Closing as stale — superseded by ongoing work. Reopen if still wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant