Repository navigation
feat(workflows): resolve workflow tool packages from declared npm dependencies - #1342
Closed
TheGreatAxios wants to merge 2 commits into
Closed
TheGreatAxios wants to merge 2 commits into
TheGreatAxios wants to merge 2 commits into
Conversation
…npm-name gate Realpath containment mirrors vendor workflow-definition-loader: rejects interchange.tools escapes through file or directory symlinks. Gate dep names with ToolPackagePinName so keys like ../../evil cannot escape node_modules. Adds 3 regression tests.
Collaborator
Author
|
Closing and canceling CL-4473: superseded by the hub-package-registry provisioning direction (CL-10430) — npm-deps resolution is the wrong foundation now, and this branch's static-analysis check is red. Work is being tracked/absorbed by the package-registry approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First slice of CL-4473: workflows declare tool packages as npm dependencies, and
resolveWorkflowToolPackagesresolves those declarations against the workflow package's laid-outnode_modules/tree, returning each tool package's name, version, directory, andinterchange.toolsentry. Dependency-vs-installed mismatches (missing installs, undeclared packages, renamed directories, tool-entry path escapes) surface as typed errors. Full closure materialization from the graph stays open.Verification
bun test src/workflows/: 63 pass, 0 fail (9 new intool-packages.test.ts).bunx oxfmt --checkon touched files: clean;bunx oxlint: 0 warnings, 0 errors.tscon the new module: no errors.bun run checkdoes not pass on this tree:tsc --noEmit, dead-exports, and build all fail on sibling in-flight agent-extraction state (src/agent/directors/registry.tsimports the deleted./reviewer/package.js; dead-exportreviewerPackageinagents/reviewer/), untouched by this change.Related
Part of CL-4473