Skip to content

fix(search): allow recursive globs pinned to a literal dir - #1366

Merged
TheGreatAxios merged 5 commits into
mainfrom
cl-10240-fixsearch-allow-recursive-globs-pinned-to-a-literal-dir
Oct 9, 2026
Merged

fix(search): allow recursive globs pinned to a literal dir#1366
TheGreatAxios merged 5 commits into
mainfrom
cl-10240-fixsearch-allow-recursive-globs-pinned-to-a-literal-dir

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Allows recursive search globs to descend from a literal directory root, so pinning a search to a concrete subdirectory no longer blocks recursion.
  • Refuses dot-prefixed recursive root globs and normalizes interior .. segments in glob pin detection.
  • Search path resolution failures fail closed in tool-time-budget.ts.

Verification

  • 22/22 plugin tests pass.
  • Typecheck clean; bun run build and bun run test pass on this branch.

Fixes CL-10240

@linear-code

linear-code Bot commented Oct 9, 2026

Copy link
Copy Markdown

CL-10240

@TheGreatAxios
TheGreatAxios marked this pull request as ready for review October 9, 2026 03:02
@TheGreatAxios
fix(search): simplify literal-dir pin detection
131bec7 
Replace the stack-collapse hasLiteralBefore with a terse fold over the
collapsed prefix segments, and trim over-verbose test comments.
@TheGreatAxios
test(search): pin interior-dotdot-after-pin glob edge case
7dfc196
@TheGreatAxios
TheGreatAxios merged commit 19d59bb into main Oct 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TheGreatAxios