Repository navigation
docs(tui): state and pin the bounded ask_director stall policy - #1387
Merged
TheGreatAxios merged 1 commit intoOct 13, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
bwachman
force-pushed
the
cl-10206-document-and-pin-the-bounded-stall-policy-for-parked
branch
from
October 11, 2026 20:18
c49a471 to
71790d4
Compare
bwachman
force-pushed
the
cl-10206-document-and-pin-the-bounded-stall-policy-for-parked
branch
from
October 11, 2026 20:50
1b33234 to
7e1e070
Compare
bwachman
changed the base branch from
main
to
cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt
October 11, 2026 20:50
TheGreatAxios
dismissed
their stale review
October 12, 2026 02:53
Superseded: summary body was posted as a literal path by a tooling slip; resubmitted with the correct summary text.
TheGreatAxios
previously requested changes
Oct 12, 2026
TheGreatAxios
left a comment
Collaborator
There was a problem hiding this comment.
Code is sound and the docs+test change is exactly as described — verified against head by an independent review fleet (34/34 targeted tests, kill-switch confirmed). Two nits only: tautological test assertions and a displaced duplicate comment. Requesting changes for the test cleanup; nothing behavior-related.
bwachman
force-pushed
the
cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt
branch
from
October 13, 2026 00:50
6dbf144 to
b64e31a
Compare
bwachman
force-pushed
the
cl-10206-document-and-pin-the-bounded-stall-policy-for-parked
branch
from
October 13, 2026 00:50
7e1e070 to
8890609
Compare
Contributor
|
@bwachman, please address the following:
|
TheGreatAxios
force-pushed
the
cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt
branch
from
October 13, 2026 02:24
b64e31a to
34e517c
Compare
TheGreatAxios
force-pushed
the
cl-10206-document-and-pin-the-bounded-stall-policy-for-parked
branch
from
October 13, 2026 02:32
8890609 to
ede3f14
Compare
TheGreatAxios
changed the base branch from
cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt
to
main
October 13, 2026 02:32
TheGreatAxios
dismissed
their stale review
October 13, 2026 02:46
Nits only: tautological abort assertion and a repeated comment. Stall timing is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ask_directorwait next to the code: it is bounded, never exempt. The TUI primary mounts neitherwait_agentsnorask_director, so both names inisStallBoundedToolNameare defensive guards. An unanswered ask expires afterASK_DEADLINE_MS(30 minutes) viaexpireStaleAsks, and the stall watchdog aborts the director's silent ask-wake turn viaabortStalledWakeTurn, which re-surfaces the question.ask_director.ask_directorcall (direct, and mapping-only). At each threshold (quiet one ms before the notice, notice at it, notice one ms before the timeout, abort at it) it assertsstallLevelandshouldAbortForStall.No logic, threshold or deadline changes.
Verification
After the rebase onto main and the review fixes, CI passes on 8890609; the results below are from the original verification.
bun run checkpasses (lint, typecheck, dead exports, build, full test suite: 8574 pass, 0 fail)ask_directorfromisStallBoundedToolNamemakes both new test cases failFixes CL-10206