Repository navigation
feat(tui): add Reject and stop to the permission prompt - #1388
Merged
TheGreatAxios merged 2 commits intoOct 13, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
bwachman
force-pushed
the
cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt
branch
from
October 11, 2026 20:18
50197db to
409a85d
Compare
bwachman
force-pushed
the
cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt
branch
from
October 11, 2026 20:50
409a85d to
6dbf144
Compare
bwachman
changed the base branch from
main
to
cl-10437-show-accepted-but-unread-queued-input-while-the-dispatcher
October 11, 2026 20:50
TheGreatAxios
requested changes
Oct 12, 2026
TheGreatAxios
left a comment
Collaborator
There was a problem hiding this comment.
Grant safety verified — Reject-and-stop is clean: the STOP outcome is always {allow:false}, shares stopDecisionGate with Ctrl+C, and queued gates are denied without approval. Four nits: the narrow-width "Ctrl+C stop" claim, an off-by-one tier comment, a weak width assertion, and an index-based test helper.
bwachman
force-pushed
the
cl-10437-show-accepted-but-unread-queued-input-while-the-dispatcher
branch
from
October 13, 2026 00:50
7e4fdd5 to
9cfed0e
Compare
bwachman
force-pushed
the
cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt
branch
from
October 13, 2026 00:50
6dbf144 to
b64e31a
Compare
Contributor
|
@bwachman, please address the following:
|
TheGreatAxios
force-pushed
the
cl-10437-show-accepted-but-unread-queued-input-while-the-dispatcher
branch
from
October 13, 2026 01:51
9cfed0e to
864a948
Compare
TheGreatAxios
force-pushed
the
cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt
branch
from
October 13, 2026 02:24
b64e31a to
34e517c
Compare
TheGreatAxios
changed the base branch from
cl-10437-show-accepted-but-unread-queued-input-while-the-dispatcher
to
main
October 13, 2026 02:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stopDecisionGate()), so both paths abort the reservation, close the overlay and interrupt the turn the same way.Verification
After the rebase onto main and the review fixes, CI passes on b64e31a; the results below are from the original verification.
bun run checkpasses (lint, typecheck, dead exports, build, full test suite: 8576 pass, 0 fail)Fixes CL-10218