Skip to content

feat(tui): add Reject and stop to the permission prompt - #1388

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt
Oct 13, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt

Conversation

@bwachman

@bwachman bwachman commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds a "Reject and stop" row to the permission prompt, listed separately from Reject. It declines the open call with the same non-persistent outcome as Reject, then interrupts the turn and denies any queued prompts without approving them. It never mints, widens or persists a grant.
  • Shares one stop sequence between this row and Ctrl+C inside a decision gate (stopDecisionGate()), so both paths abort the reservation, close the overlay and interrupt the turn the same way.
  • Keeps "Ctrl+C stop" in the permission hint line down to contentWidth 28; below that the title falls back to " Permissions".
  • Reject keeps its meaning: it declines only the open call and the turn continues.

Verification

After the rebase onto main and the review fixes, CI passes on b64e31a; the results below are from the original verification.

  • bun run check passes (lint, typecheck, dead exports, build, full test suite: 8576 pass, 0 fail)
  • Tests pin each behavior, including "Reject and stop declines the open gate and drops queued gates", "plain Reject declines only the open gate and the turn continues", and "permission title hints keep Ctrl+C stop down to contentWidth 28"

Fixes CL-10218

@linear-code

linear-code Bot commented Oct 10, 2026

Copy link
Copy Markdown

CL-10218

@bwachman
bwachman force-pushed the cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt branch from 50197db to 409a85d Compare October 11, 2026 20:18
@bwachman
bwachman force-pushed the cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt branch from 409a85d to 6dbf144 Compare October 11, 2026 20:50
@bwachman
bwachman changed the base branch from main to cl-10437-show-accepted-but-unread-queued-input-while-the-dispatcher October 11, 2026 20:50
Comment thread src/tui/overlay-view.ts Resolved
Comment thread src/tui/overlay-view.test.ts Resolved
Comment thread src/tui/overlay-view.test.ts Resolved
Comment thread src/tui/runtime-bridge.test.ts Resolved

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grant safety verified — Reject-and-stop is clean: the STOP outcome is always {allow:false}, shares stopDecisionGate with Ctrl+C, and queued gates are denied without approval. Four nits: the narrow-width "Ctrl+C stop" claim, an off-by-one tier comment, a weak width assertion, and an index-based test helper.

@bwachman
bwachman force-pushed the cl-10437-show-accepted-but-unread-queued-input-while-the-dispatcher branch from 7e4fdd5 to 9cfed0e Compare October 13, 2026 00:50
@bwachman
bwachman force-pushed the cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt branch from 6dbf144 to b64e31a Compare October 13, 2026 00:50
@corbits-triage

corbits-triage Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

@bwachman, please address the following:

  • required checks are failing: build-and-test, test (src), eslint, prettier, typecheck, test (3/4), test (4/4), build, test (1/4), test (2/4), static-analysis

@TheGreatAxios
TheGreatAxios force-pushed the cl-10437-show-accepted-but-unread-queued-input-while-the-dispatcher branch from 9cfed0e to 864a948 Compare October 13, 2026 01:51
@TheGreatAxios
TheGreatAxios force-pushed the cl-10218-add-a-reject-and-stop-choice-to-the-permission-prompt branch from b64e31a to 34e517c Compare October 13, 2026 02:24
@TheGreatAxios
TheGreatAxios changed the base branch from cl-10437-show-accepted-but-unread-queued-input-while-the-dispatcher to main October 13, 2026 02:24
@TheGreatAxios
TheGreatAxios merged commit 4298f25 into main Oct 13, 2026
15 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants