Repository navigation
feat(subagent): classify terminal subagent failures with typed record - #1391
Merged
TheGreatAxios merged 3 commits intoOct 13, 2026
Conversation
bwachman
force-pushed
the
cl-10202-surface-terminal-subagent-provider-failures-with-actionable
branch
from
October 11, 2026 20:18
9a71c76 to
633c75a
Compare
bwachman
force-pushed
the
cl-10202-surface-terminal-subagent-provider-failures-with-actionable
branch
from
October 11, 2026 20:50
d4ad7ef to
3347ae6
Compare
bwachman
changed the base branch from
main
to
cl-10469-surface-off-tag-build-identity-in-tui-version-badge
October 11, 2026 20:50
TheGreatAxios
requested changes
Oct 12, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
There was a problem hiding this comment.
Typed failure record implemented as claimed — classification, once-only cleanup, handoff gating, and the no-spawn-behavior-change invariant all verified (904/0 subagent suite). Three items: follow-up-turn failures bypass the classifier (should-fix — same failure records 'interrupted' via send_input vs 'provider_retryable' via resume_agent), ~270 comment-only lines referencing unrelated tickets, and the body's AC-to-code line map is stale after the rebase.
AC2 cites agent-fleet.ts:2168-2176 (past EOF; file is 2146 lines; actual 487-505/2123); AC8 cites session-store.ts:1690-1702 (actual handoff evidence 1589-1600); AC4/AC5 shifted after rebase (run.ts:692-694; session-store.ts:790-818). Refresh the map at head.
Plain: the description's line references point at the wrong places — one past the end of the file — after a rebase. Update them.
corbits-triage
Bot
added
triage:needs-author-update
and removed
triage:awaiting-review
labels
corbits-triage
Bot
added
Triage: Needs changes
and removed
triage:needs-author-update
labels
bwachman
force-pushed
the
cl-10469-surface-off-tag-build-identity-in-tui-version-badge
branch
from
October 13, 2026 00:50
30e4eca to
fb9b903
Compare
bwachman
force-pushed
the
cl-10202-surface-terminal-subagent-provider-failures-with-actionable
branch
2 times, most recently
from
October 13, 2026 00:52
7d1bdcf to
3dbdbc3
Compare
bwachman
force-pushed
the
cl-10469-surface-off-tag-build-identity-in-tui-version-badge
branch
from
October 13, 2026 00:52
fb9b903 to
b406132
Compare
TheGreatAxios
force-pushed
the
cl-10469-surface-off-tag-build-identity-in-tui-version-badge
branch
from
October 13, 2026 02:49
b406132 to
169e718
Compare
A failed worker reached the parent as two booleans and error prose, so the parent could not tell a transient provider fault from a stuck or cancelled lane, and an answered ask_director left no trace once the run died. The store now writes one frozen failure record in the same mutation that makes a non-clean terminal visible, and provider_failure and continuable derive from its class so every projection agrees.
The reactor's doom-loop guard already stops workers, but the run ended as a plain error and its class survived only in the reactor message. The doom_loop run end reaches the stream after the send rejects, so the run notes it in its stream sink and rethrows a typed error once teardown has drained the stream. A forced-stop reason would have taken the salvage path and turned the failed lane into a done one. The run also reports when its own teardown fails, which is the release step behind a partial cleanup outcome.
TheGreatAxios
force-pushed
the
cl-10202-surface-terminal-subagent-provider-failures-with-actionable
branch
from
October 13, 2026 02:54
3dbdbc3 to
694fbd2
Compare
TheGreatAxios
changed the base branch from
cl-10469-surface-off-tag-build-identity-in-tui-version-badge
to
main
October 13, 2026 02:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1 of 2: classification and record (stack base)
This is PR 1 of the two-PR CL-10202 delivery. It adds typed failure classification and the failure record, with no behavior change to spawning. The stacked follow-up PR 2 (enforced recovery,
recoversonspawn_agent) builds on this branch.Summary
terminal_failurerecord with afailure_classfield, replacing prose-parsed failure strings.loop_guard, distinct from provider-level failures.recovery.availablemirrors today'scontinuable(invariantcontinuable === recovery.available) and thecontinue_withtext is unchanged.Verification
After the rebase onto main and the review fixes, CI passes on 3dbdbc3; the results below are from the original verification.
Gates run independently on tip 9a71c76 (exit code 0 everywhere):
AC to code and test mapping
Deferred / Notes
Refs CL-10202