Repository navigation
feat(tui): show required operator input at the composer - #1393
TheGreatAxios merged 1 commit into
Conversation
62feb32 to
dc48681
Compare
dc48681 to
0481351
Compare
TheGreatAxios
left a comment
There was a problem hiding this comment.
Strip implementation is sound — fails-closed eligibility, settle-once across every terminal path, and overlay/routing invariance all verified (221/0 on the PR's own gate). Five items: one should-fix (strip not cleared on session clear), a same-id duplicate to pin, a doc overstatement, a comment omission, and a wrong AC1 test mapping in the body.
AC1 credits operator-input-required.test.ts for "persistence incl. live theme switch"; the live-switch test is in operator-input-required-chrome.test.ts:183 and the unit test is view-model-only. Fix the mapping.
0481351 to
8638639
Compare
b72ebc9 to
108bae6
Compare
|
AC1 mapping fixed in the PR body: the live theme switch test is in |
8638639 to
b1b64b2
Compare
Note on base
This branch is stacked on the
cl-10200-make-parked-worker-ask_director-questions-visible-andbranch (tip 108bae6), which provides the worker-wait / parked-question machinery this feature coexists with. The diff in this PR is the CL-10189 change only.Summary
Show the required operator input at the composer: when a primary session's ask_operator gate requires operator input, a persistent, theme-aware, width-safe INPUT REQUIRED strip renders in the composer-adjacent row with a provenance marker. The strip is keyed and deduped by OperatorGateEvent.id, only the primary ask_operator is eligible (fails closed for MCP/unmarked/permission/ask_director/OAuth), and every terminal path removes exactly the settled ID. Overlay and routing behavior are unchanged.
Verification
After the rebase onto main and the review fixes, CI passes on 8638639; the results below are from the original verification.
bun test src/tui/operator-input-required.test.ts src/tui/operator-input-required-chrome.test.ts src/tui/gate-wire.test.ts src/tui/product-host.test.ts src/tui/worker-wait.test.ts src/tui/worker-wait-chrome.test.ts src/tui/geometry.test.ts src/tui/runner/session.operator-input-required.test.tsAll 7 findings in CL-10189-review-v2.md resolved (geometry invariant; gate-wire same-ID drop removed with two-distinct-objects tests; AC4 free-text/Esc/timeout route + product-host teardown + Phase-4 session integration; AC1 persistence incl. live theme switch; wrong-marker test; stale comments; plan negatives).
AC to code and test mapping
Deferred / Notes
Refs CL-10189