Skip to content

refactor(config): drop dead guards and duplicate profile expression #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 1 commit into from
Oct 12, 2026
Merged

refactor(config): drop dead guards and duplicate profile expression #1399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,9 +757,7 @@ export class CliHelpError extends Error {
}

/** Printed for `corbits --version` / `-V`. Matches `package.json` version. */
export const CLI_VERSION_TEXT = `${COMMAND_NAME} v${
typeof pkg.version === "string" ? pkg.version : "0.0.0"
}`;
export const CLI_VERSION_TEXT = `${COMMAND_NAME} v${pkg.version}`;

/**
* Thrown when the operator asked for the CLI version. Entry points must print
Expand Down
2 changes: 1 addition & 1 deletion src/config/profiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export async function resolveProfile(
merged.summarizerTimeoutMs = projectProfile.summarizerTimeoutMs;
}

const resolvedName = profileName ?? projectProfile?.profile;
const resolvedName = namedProfileName;
if (resolvedName !== undefined) merged.profile = resolvedName;

return merged;
Expand Down
7 changes: 4 additions & 3 deletions src/exec/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,9 +646,10 @@ export async function runExec(config: Config): Promise<ExecResult> {
});
},
});
const sessionMode: SessionMode =
resolveSessionMode(config.settings, localSettingsForMode) ??
"orchestrator";
const sessionMode: SessionMode = resolveSessionMode(
config.settings,
localSettingsForMode,
);

const interactive = resolveExecInteractive({
stdinTTY: input.isTTY,
Expand Down
Loading