Repository navigation
refactor(scripts): dedupe percentile and release helpers - #1403
Merged
Merged
Conversation
Contributor
|
Not yet confirmed, a maintainer will check:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
percentileimplementations (approval-forensics, intervention-forensics, tool-fingerprint-forensics) into one sharedscripts/percentile.ts; the tool-fingerprint copy's closure signature is converted to the shared(sorted, p)signature with identical values at its call sites.FORMULA="$BINARY"alias fromscripts/release.sh; all package paths useBINARYdirectly.scripts/verify-corbits-only-scope.sh; the fall-through prints the same OK line and exits 0.scripts/release.shwith onecopy_pluginshelper.scripts/release.shwith oneis_blankhelper.Verification
bun test scripts/verify-corbits-only-scope.test.ts— 3 pass / 0 fail (includes the empty-change-set case that exercises the removed early exit's fall-through)bun run typecheck— passes (exit 0); pre-commit hook also ran typecheck +bun build ./src/index.ts, both passoxfmt --checkandoxlinton the changed TS files — pass (0 warnings / 0 errors)bash -n scripts/release.sh scripts/verify-corbits-only-scope.sh— both pass; release.sh changes verified by reading, not run end-to-endFixes CL-10528