Skip to content

refactor(scripts): dedupe percentile and release helpers - #1403

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-10528-scripts-dedupe
Oct 12, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-10528-scripts-dedupe

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Hoist the three duplicated percentile implementations (approval-forensics, intervention-forensics, tool-fingerprint-forensics) into one shared scripts/percentile.ts; the tool-fingerprint copy's closure signature is converted to the shared (sorted, p) signature with identical values at its call sites.
  • Drop the legacy FORMULA="$BINARY" alias from scripts/release.sh; all package paths use BINARY directly.
  • Remove the redundant early exit from scripts/verify-corbits-only-scope.sh; the fall-through prints the same OK line and exits 0.
  • Replace the two identical plugin-copy blocks in scripts/release.sh with one copy_plugins helper.
  • Replace the duplicated blank-section checks in scripts/release.sh with one is_blank helper.

Verification

  • bun test scripts/verify-corbits-only-scope.test.ts — 3 pass / 0 fail (includes the empty-change-set case that exercises the removed early exit's fall-through)
  • bun run typecheck — passes (exit 0); pre-commit hook also ran typecheck + bun build ./src/index.ts, both pass
  • oxfmt --check and oxlint on the changed TS files — pass (0 warnings / 0 errors)
  • bash -n scripts/release.sh scripts/verify-corbits-only-scope.sh — both pass; release.sh changes verified by reading, not run end-to-end

Fixes CL-10528

@linear-code

linear-code Bot commented Oct 12, 2026

Copy link
Copy Markdown

CL-10528

@corbits-triage

Copy link
Copy Markdown
Contributor

Not yet confirmed, a maintainer will check:

  • tests cover the change

@TheGreatAxios
TheGreatAxios merged commit e082644 into main Oct 12, 2026
13 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-10528-scripts-dedupe branch October 12, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant