Repository navigation
refactor(packages): drop no-op export, dedupe helpers - #1404
Merged
Merged
Conversation
Contributor
|
No changes needed from you. A maintainer will review this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connectListProvidersexport (it returnedFIRST_CLASS_PROVIDERSunchanged) and its test; no host re-exports it.buildGoCatalogEntrybuilds its protocol map from the sharedPROTOCOL_BY_IDinstead of re-iterating the model array.formatGoUsageformats via named helpers (formatUsagePercent,usageWindowLabel) instead of nested ternaries.hostMatchesOpencodeDotAihelper (homed inopencode-go, imported byzen) with the same boolean outcome at each site.Verification
connectListProvidersreferenced only byproviders.test.ts; not re-exported inindex.ts— deleted export and test.PROTOCOL_BY_IDderives from the sameOPENCODE_GO_MODELSids/protocols as the replaced loop;Object.fromEntries(PROTOCOL_BY_ID)yields an identical map.pctpercent / dollars / "ok"; window 5h / week / month).isOpenCodeGoURLandisZenURLkeep identical host-match outcomes — Go inverts the shared helper.bun test packages/opencode-go/src packages/zen/src packages/first-class-providers/src— 57 pass, 0 fail.bun run typecheck— passes.oxlintandoxfmt --checkon changed files — clean.Fixes CL-10530