Repository navigation
fix(provider): recover Codex parallel call arguments sent only on done - #1414
Merged
TheGreatAxios merged 1 commit intoOct 13, 2026
Conversation
Contributor
|
No changes needed from you. A maintainer will review this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response.output_item.doneand streams nofunction_call_arguments.deltaevents. Calls that do stream deltas are unchanged.withParallelToolCalls, the host override that turns parallel calls on for Codex, because that override is what exposes this backend behavior; the packaged parser reads arguments from deltas alone.Without this, the Codex backend's no-delta path reaches the tools with every call's arguments as
{}(the harness assembles an empty buffer as{}), so parallel fan-outs such as severalspawn_agentcalls fail argument validation and nothing starts.Verification
bun run checkpasses (lint, typecheck, dead exports, build, full test suite: 8665 pass, 0 fail)parallel-tools-arguments-on-done.jsonreproduces the no-delta shape; its test fails without the change and passes with it, and the existing streamed-call fixture produces the same events as beforecodex/plus(gpt-5.6-terra) that hit the no-delta path read three files in parallel with full arguments on the first attemptFixes CL-10582