Repository navigation
refactor(tools): derive tool inputSchemas from arktype types - #1425
Merged
TheGreatAxios merged 3 commits intoOct 15, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
Hand-written JSON Schema for web_fetch, web_search and delete_file duplicated the arktype arg types and had already drifted (no minLength, documented timeout intent living outside the schema). The types are now the single source via toJsonSchema with descriptions carried as arktype metadata; served shape keeps its exact key set (dialect: null) and generated-vs-hand diffs are pinned in tests. arktype moves 2.2.3 -> 2.2.8; an override keeps the first-party and vendored consumers on one type identity (two arktype versions in one program defeat portable type naming).
Contributor
|
Superseded by the comment below. |
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Needs Human Review
labels
Contributor
|
Superseded by the comment below. |
Contributor
|
Triage: Fail @TheGreatAxios, please address the following:
|
TheGreatAxios
changed the base branch from
cl-10654-isomorphic-git-1442-batch-remove-hot-path-perf
to
main
October 15, 2026 19:47
…generate-inputschema-via-tojsonschema-delete-ha # Conflicts: # bun.lock
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Not Ready
and removed
Triage: Not Ready
Triage: Needs Human Review
labels
appendFile creates partial.jsonl before the JSON line is written, so a reader can observe empty or truncated JSON. Rewrite through a temp file and rename, and serialize overlapping flushes so one publish cannot drop the other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dialect: null; generated-vs-hand diffs pinned with full-object assertions.minLength: 1on required strings the hand JSON dropped; enums lower toanyOf/const(arktype fixed behavior). Timeout intent stays as type metadata; runtime clamping remains the enforcement point (unchanged).overridesentry pinning arktype 2.2.8 — note@corbits/openai-responses@0.2.1declares an exact2.2.3pin, so that published dep now validates against 2.2.8 (in-range for its ^2.2.3 consumers elsewhere; flagged here deliberately).src/agent/*tool declarations still hand-write/extend schemas.Verification
bun run checkexit 0: full suite 8942 pass / 0 fail across 580 files.Fixes CL-10652