Repository navigation
fix(authz): redact capability ids and scrub persisted approval args - #1426
Merged
TheGreatAxios merged 2 commits intoOct 15, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
Correlation ids are bearer capabilities (see the provenance gate): log and receipt sites now emit a truncated+hashed form, so a log reader no longer becomes a forgery actor. Approval-snapshot arguments are secret- scrubbed at the persisted-metadata boundary (live calls untouched), and credential headers freeze at the source cell. The vendored raw-warn sites are unreachable from the app path and are dispositioned in the vendor ledger; retry policies are documented trusted-first-party-only.
Contributor
|
Superseded by the comment below. |
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Needs Human Review
labels
Contributor
|
Superseded by the comment below. |
Integrity compare no longer collapses every secret to one redaction token. Redacted-at-rest snapshots still match the live call; raw re-dispatch arguments must match exactly.
Contributor
|
This supersedes the comment above because the rules changed: repository policy version 16 → version 19. Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
changed the base branch from
cl-10678-security-authenticate-approval-correlation-validator-gate
to
main
October 15, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redactedCorrelationId— prefix + sha-256 fragment, ~90 bits residual on a v4 UUID) instead of the bearer capability; a log reader no longer becomes a forgery actor. Event-sink audit recorded in PR: run.json carries status/usage only,message.correlated/gate.blockedfan out to in-memory consumers,metadata.jsonpersists IDs by design for restart-resume.scopedPendingSnapshotScrubover every pending op inwriteMetadata); live calls and the vendoredsuspendedCallre-dispatch path stay raw — snapshot-fidelity comparison normalizes both sides through the same scrub, so recovery of parked approvals with secret-carrying args still succeeds (regression test covers the exact flow that would otherwise failsnapshot-mismatch).CredentialMaterialfreezes at the source cell (shallow freeze on the material + its string-valued headers; callers receive copies); no production writer mutates headers afterwards; never logged.harness.ts:1749raw-warn is unreachable by app flow today and ledgered as an upstream promotion candidate, along with the vendoredprocessDeliveryfatal path that interpolates the full ID); the persisted-at-restsuspendedCall.argumentsgap for the vendored re-dispatch owner is named in the ledger.assertReplySendandApprovalDeliveryTimeoutErrorredacted to the hashed form while keeping structured.correlationIdprops.Verification
persistedHasSecret=true), redacted after; recovery flow passthrough asserted.writeMetadata→resolveSuspendedApprovalFromStoresucceeds post-scrub (the flow that failed during review is now pinned green).bun run checkexit 0: full one-process suite 8965 pass / 0 fail across 584 files;git diff --stat -- vendor/empty.Fixes CL-10679