Repository navigation
refactor(logging): collapse double-log storms, fix levels, correlate ids - #1430
Merged
TheGreatAxios merged 3 commits intoOct 15, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
Second-layer duplicates (store settlement, submit sent-append) collapse to single entries; per-field trust warn storms become one summary warn, with a per-file error shape on the migration result. Mis-leveled errors demote to warn; warn churn during teardown demotes to debug. caughtDebug is the single append-failure helper for persist/teardown catches. The exec/exit error paths it guards carry sessionId from where the id is already in scope; the MCP late-connect/retry warns name the server. The collapsed per-entry absolute resolution uses an explicit lambda (paths.map((p) => resolve(p))) so map's (value, index, array) triple can never reach path.resolve — avoiding the plan draft's would-crash shape (probe-verified: restoring bare .map(resolve) fails the trust store suite with ERR_INVALID_ARG_TYPE). The parent commit always had the safe per-entry loop; nothing here fixes a shipped crash. The migration's one-summary-warn contract is pinned by a log-capture test listing each skipped store.
Contributor
|
Superseded by the comment below. |
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Needs Human Review
labels
Contributor
|
Superseded by the comment below. |
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
changed the base branch from
cl-10663-shell-sandboxing-adopt-sandbox-runtime-opt-in-fail-closed
to
main
October 15, 2026 21:18
…nup-collapse-storms-fix-levels-add-correla # Conflicts: # src/tui/runner/exit.ts
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Not Ready
Triage: Needs Human Review
labels
A final steer whose promise rejects was silent after settlement. Log that failure again with the same id and error shape as the handoff path, and drop the narration comments added with the collapse.
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Ready
Triage: Needs Human Review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorshape on the migration result (pinned by a log-capture test that lists each skipped store).tui/runner/mcplate-connect/retry errors→warn with server correlation; summarizer retry-path warns and otel-sink soft-skip warns demote to debug (terminal failure still warns — no suppressed terminal error).caughtDebugappend-failure helper replacing 15+ per-site catch closures in settings/exit/dispose/runner paths; all migrated message templates byte-identical (parity checked site-by-site). The exec/exit error paths it guards now carrysessionIdfrom where the id is already in scope — scope-honest, no new threading..catch()handlers on a never-rejceting pricing load (fallback path verified internal toloadPricing).map's(value, index, array)triple can never reachpath.resolve(probe-verified crash shape from the plan draft, avoided — the pre-existing committed loop was already safe).Verification
bun run checkexit 0: 8968 pass / 0 fail across 584 files; scoped trust/logging/permission suites 74 pass / 0 fail.smoke.tsprobe, stderr user channel, sink debug default,reactor-authorizepair — all untouched (diff-verified).e1c3faf3→1bfc0735base carries this commit's parent.Fixes CL-10661