Skip to content

chore: delete five verified-dead artifacts - #1432

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-10671-dead-code-no-op-flag-shim-unread-settings-stub-dead
Oct 15, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-10671-dead-code-no-op-flag-shim-unread-settings-stub-dead

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Deletes five grep-verified dead artifacts (~net −90 lines over 12 files): the --no-workflow no-op flag chain (parse clause, field, thread-through, test, fixture — never help-listed), the incompleteReportNudgeFired stop-policy shim (sole caller already passes the newer counter parameter; nudge-once-then-stop parity preserved), the never-read workflowProfiles + compactionMode settings (arktype ignores undeclared keys, so legacy settings files still load — the keys just stop persisting, same as the established tiers legacy-drop behavior), the empty workflows/_stub package (workspace glob retained), and the in-repo CODEX_HEADLESS_REFRESH_INTERVAL_MS constant + dead CODEX_REFRESH_SKEW_MS re-export (the vendored constant survives, consumers import it from the provider directly).
  • Every deletion carries repo-wide zero-caller evidence at deletion time; the dead-export gate's allowlist shrinks by the same two entries and self-verifies by failing on stale rows.
  • Verified-live artifacts stay untouched (sessionMode runtime machinery, .agent-state dual-read, forensics/perf/eval scripts, bin/*), and no visible flag/alias renames (CL-10672's territory).

Verification

  • bun run check exit 0: 8967 pass / 0 fail across 584 files; scoped suites: src/config 302, src/subagent 959, exec-signal + codex + check-dead-exports 98 all green.
  • One documented pre-existing flake surfaced during gate runs (e2e/exec-signal-finalize.test.ts SIGTERM timing), reproduced on the untouched base and unrelated to this change; the branch passes it green on reruns.
  • Independent deletion review re-grepped all five artifacts post-deletion and verified the shim fold's falsy-vs-nullish parity against the actual caller contract.

Fixes CL-10671

A no-op flag parsing clause with its fixture, a stop-policy shim whose
sole caller is a newer parameter, two settings that nothing reads, the
stub workflows package, and a Codex refresh constant with an unused
re-export in this repo. Every item carries repo-wide zero-caller
evidence at deletion time; the dead-export gate's allowlist shrank by
the same two entries and re-verifies by failing on stale rows. Live
artifacts (sessionMode machinery, .agent-state dual-read, scripts,
bin/) stay as they are.
@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown

CL-10671

@corbits-triage

corbits-triage Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by the comment below.

@corbits-triage

corbits-triage Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by the comment below.

@corbits-triage

corbits-triage Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

@TheGreatAxios
TheGreatAxios changed the base branch from cl-10661-logging-cleanup-collapse-storms-fix-levels-add-correla to main October 15, 2026 21:31
…-op-flag-shim-unread-settings-stub-dead

# Conflicts:
#	scripts/check-dead-exports.test.ts
#	scripts/dead-export-allowlist.txt
@TheGreatAxios
TheGreatAxios merged commit 8beff11 into main Oct 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant