Repository navigation
fix(session): surface swallowed store/resume errors instead of silent defaults - #1436
Merged
TheGreatAxios merged 1 commit intoOct 15, 2026
Conversation
Contributor
|
Superseded by the comment below. |
Contributor
|
Superseded by the comment below. |
… defaults A torn permissions approvals file read back as an empty store and any subsequent grant write permanently discarded prior allow-always grants with nothing surfaced; reads now distinguish ENOENT from corruption and a corrupt file aborts before the read-modify-write can clobber. Stall-after-interrupt approvals collapsed every resume-path throw into a bare 'refused' that looked identical to a system decline; the refusal now carries a scrubbed cause and a structured warn. The seven silent swallow sites (aged image markers, dropped handoffs, compaction evidence, corrupt MCP oauth backup, evidence-archive skips, drain failures, stale model picker) each log with their identifier.
TheGreatAxios
force-pushed
the
cl-10673-swallowed-errors-grants-loss-opaque-approval-refus
branch
from
October 15, 2026 06:12
4f6d5f6 to
f9055ed
Compare
Contributor
|
This supersedes the comment above because the rules changed: repository policy version 16 → version 19. Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
changed the base branch from
cl-10679-security-hygiene-redact-capability-ids-credential
to
main
October 15, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refused("error")that looked identical to a system decline: the refusal now carries a scrubbed cause (error class + message with secret shapes AND correlation-ID shapes neutralized before the warn line) and a structured warn with the redacted correlation id; turn-marker consumers are shape-stable (onlyhandled/coderead)..corruptbefore overwrite, evidence-archive skips, stream-journal drain failures, stale model picker) each log with their identifying context; archived-skip receipts scrub on both success and error paths. Stretch items: oauth scope-check causes name the HTTP status or a timed-out probe; upgrade skip reasons nameclass: message.Verification
bun run checkexit 0: 8,975 pass / 0 fail across 584 files; targeted store/resume/auth/upgrade suites green.Fixes CL-10673