Repository navigation
refactor(config): fold duplicate flag spellings into single parse paths - #1438
Merged
TheGreatAxios merged 2 commits intoOct 15, 2026
Merged
Conversation
The exec/run/-p trio, the resume family, the yolo spellings, and the telemetry kill-switches each carried parallel handling for one operator knob apiece; internal alias maps now own the surface (--pick/--list stay flow-specific errors everywhere else). OAuth provider/model selection collapses three projection helpers into one ordered chain at loadConfig; OTEL environment overrides now win wholesale over settings resource attributes — including a set-but-empty value, which races nothing in from settings (documented in PERFTRACE). topP is documented deprecated-but-honored next to temperature. The always-overridden defaults turned out to be live fallbacks or single definitions and stay, recorded. Implementation documents the settings precedence; perfectrace documents the OTEL rule.
Contributor
|
Superseded by the comment below. |
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Needs Human Review
labels
Contributor
|
Superseded by the comment below. |
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
changed the base branch from
cl-10671-dead-code-no-op-flag-shim-unread-settings-stub-dead
to
main
October 15, 2026 21:38
Inline applyOAuthProviderProjections back into loadConfig and remove comments that only restate alias spellings. Flag parse results are unchanged.
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Ready
Triage: Needs Human Review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-pfolds into the exec pre-scan); resume/continue/--pick/--list collapse into one picker flow with deliberate flow-scoped "unrecognized flag" errors preserved elsewhere; yolo spellings go through oneSKIP_PERMISSIONS_FLAGSalias set; telemetry kill-switches collapse to one env name (DO_NOT_TRACK canonical, legacyCORBITS_TELEMETRYalias) + one setting, and OTEL gain the wholesale env-wins rule including its documented set-but-empty edge (a value of""replaces configured resource attributes with nothing, consistent with the existing empty-headers rule — documented + test-pinned).loadConfig; ordering tests pin defaults-before-sweep-before-overlay verbatim.topPis documented deprecated-but-honored besidetemperature; the always-overridden defaults turned out to be live fallbacks/single definitions and remain.docs/IMPLEMENTATION.md(precedence, sampling, auto) +docs/PERFTRACE.md(OTEL wholesale, set-but-empty) carry operator-facing updates.Verification
bun run checkexit 0: 8973 pass / 0 fail (reproduced 3×; one non-deterministic unrelated flake during a rerun did not recur and was not captured — noted in review notes).Fixes CL-10672