Repository navigation
fix(permissions): add typed parent approval - #1440
Merged
TheGreatAxios merged 2 commits intoOct 15, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
TheGreatAxios
marked this pull request as ready for review
October 15, 2026 06:11
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
bwachman
force-pushed
the
cl-10696-add-typed-parent-approval-for-pending-worker-denied-calls
branch
from
October 15, 2026 17:59
5beafbd to
2067e67
Compare
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Not Ready
Triage: Needs Human Review
labels
Parked denied-call asks name approve_worker_call and the grant request id. Revoking an authorization records a revoked audit event.
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Ready
Triage: Needs Human Review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_inputnon-authoritative and binds approval strictly to the target, question, request, and denied-call identity.Verification
bun test src/permission/worker-grant.test.ts src/permission/reactor-authorize.test.ts src/subagent/lifecycle-tools.test.ts src/subagent/authority.test.ts src/subagent/run-authority.test.tspasses (96 pass, 498 assertions).git diff --checkpasses.bun run typecheckand the pre-commit build pass.bun run checkremains blocked at oxfmt preflight by pre-existing formatting failures in untrackedBUILD_PLAN.mdandSOLUTION_SCOPE.md.Fixes CL-10696