Skip to content

refactor(tools): share arg guards, bounded reads, and process spawn - #1444

Merged
TheGreatAxios merged 4 commits into
mainfrom
cl-10668-toolsplugins-de-dupe-shared-argguardspawn
Oct 15, 2026
Merged

TheGreatAxios merged 4 commits into
mainfrom
cl-10668-toolsplugins-de-dupe-shared-argguardspawn

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Tool and plugin helpers share argument guards, bounded file reads, and process spawn instead of duplicating them.
  • Bounded grep keeps regex quantifier braces when it caps a pattern.

Verification

  • bun run typecheck, bun run build, and bun run test pass

Fixes CL-10668

@linear-code

linear-code Bot commented Oct 15, 2026

Copy link
Copy Markdown

CL-10668

@corbits-triage

corbits-triage Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by the comment below.

Brace rejection stays on globs and search_files. Drop the test-only bounded-read re-export from the read-file guard.
@TheGreatAxios
TheGreatAxios force-pushed the cl-10668-toolsplugins-de-dupe-shared-argguardspawn branch from f6d2a58 to 64b93c8 Compare October 15, 2026 05:08
@TheGreatAxios
TheGreatAxios changed the base branch from main to cl-10652-arktype-228-generate-inputschema-via-tojsonschema-delete-ha October 15, 2026 05:08
The shared spawn helper had no callers, so the dead-export gate failed static analysis.
@corbits-triage

corbits-triage Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by the comment below.

@corbits-triage

Copy link
Copy Markdown
Contributor

This supersedes the comment above because the rules changed: repository policy version 19 → version 32.

Triage: Fail

@TheGreatAxios, please address the following:

  • pull request is over the files limit: 26 files (max 25)

@TheGreatAxios
TheGreatAxios changed the base branch from cl-10652-arktype-228-generate-inputschema-via-tojsonschema-delete-ha to main October 15, 2026 20:07
@TheGreatAxios
TheGreatAxios merged commit 44c66c7 into main Oct 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant