Skip to content

test: share signal fixtures and stringify hook signal codes - #1445

Merged
TheGreatAxios merged 6 commits into
mainfrom
cl-10670-test-weight-unify-stubs-merge-signal-e2e-kill-sle
Oct 15, 2026
Merged

TheGreatAxios merged 6 commits into
mainfrom
cl-10670-test-weight-unify-stubs-merge-signal-e2e-kill-sle

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

Shared helpers replace duplicated provider, auth, tool-schema, git-index, and testkit paths.

  • Provider adapters share error-body reading, JSON-rewrite and header mechanics, one Anthropic protocol identity, and one models-endpoint parser. Auth callback, login, session, store, and lock twins share seven helpers; provider-specific behavior stays explicit hooks.
  • Tool input schemas come from arktype types. Context-store index writes batch inside one acquire. The dead-export guard runs on knip instead of ts-prune.
  • Testkit shares reactor stubs, signal-aware spawn, and process waits. Shared stubs do not hide capabilities, the deleted director harness has no remaining imports, and waits still fail when the watched process or file is missing.

Verification

  • Review of the testkit change: shared stubs do not hide capabilities; the deleted harness has no remaining imports; waits still fail when the watched process or file is missing.

Fixes CL-10670

@linear-code

linear-code Bot commented Oct 15, 2026

Copy link
Copy Markdown

CL-10670

@corbits-triage

corbits-triage Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Triage: Fail

@TheGreatAxios, please address the following:

  • required checks are failing: static-analysis

@TheGreatAxios
TheGreatAxios force-pushed the cl-10670-test-weight-unify-stubs-merge-signal-e2e-kill-sle branch from 58e6511 to 0b53789 Compare October 15, 2026 05:08
Bun's signalCode is number | Signals | null. Keep the real signal as a string so HookExitStatus stays string | null without dropping numeric codes.
oxfmt --check rejected the wrapped signal field in runLifecycleHook.
Static analysis rejected an unused spawnSync import in the reap fixture
and an index signature on spawnSignalFixture extraEnv.
@TheGreatAxios TheGreatAxios changed the title refactor: share duplicated provider, auth, tool, and testkit paths test: share signal fixtures and stringify hook signal codes Oct 15, 2026
@TheGreatAxios
TheGreatAxios merged commit 20ca12e into main Oct 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant