Repository navigation
test: share signal fixtures and stringify hook signal codes - #1445
Merged
TheGreatAxios merged 6 commits intoOct 15, 2026
Merged
TheGreatAxios merged 6 commits into
TheGreatAxios merged 6 commits into
Conversation
Contributor
|
Triage: Fail @TheGreatAxios, please address the following:
|
TheGreatAxios
force-pushed
the
cl-10670-test-weight-unify-stubs-merge-signal-e2e-kill-sle
branch
from
October 15, 2026 05:08
58e6511 to
0b53789
Compare
Bun's signalCode is number | Signals | null. Keep the real signal as a string so HookExitStatus stays string | null without dropping numeric codes.
oxfmt --check rejected the wrapped signal field in runLifecycleHook.
Static analysis rejected an unused spawnSync import in the reap fixture and an index signature on spawnSignalFixture extraEnv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shared helpers replace duplicated provider, auth, tool-schema, git-index, and testkit paths.
Verification
Fixes CL-10670