Repository navigation
feat(tui): route runtime notices through the console overlay - #1450
Merged
Merged
Conversation
Contributor
|
Superseded by the comment below. |
Contributor
|
Triage: Fail @TheGreatAxios, please address the following:
|
TheGreatAxios
changed the base branch from
cl-10647-tui-staged-bump-opentuicore-0512-0517-064
to
main
October 15, 2026 19:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.infointo the OpenTUI console overlay whenconsoleModeisconsole-overlay.surfaceSystemNoticeand are not mirrored. The overlay stays hidden unlessSHOW_CONSOLEis set; the file log sink stays mandatory.consoleModeandclock. A kill-ring chord test drives Ctrl+U / Ctrl+Y through mock keys.Verification
bun test src/tui/runtime-notices-console.test.ts src/tui/prompt-kill-ring.test.ts src/tui/runtime-notices.test.tspasses (39 tests, exit 0)tsc --noEmitandbun buildpass on both commits@opentui/core0.6.4testing.d.tsre-exports test-renderer, mock-keys, mock-mouse, mock-tree-sitter-client, terminal-capabilities, spy,ManualClock, andTestRecorder.testing/test-renderer.d.tsaddsdisposeandSymbol.asyncDispose;TestRendererOptionsextendsCliRendererConfig, soclockandconsoleModepass through. The harness still destroys viarenderer.destroy().Fixes CL-10641