Skip to content

feat(tui): route runtime notices through the console overlay - #1450

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-10641-console-overlay-notices
Oct 15, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-10641-console-overlay-notices

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Confirmation flashes stay on the status row and are also mirrored with console.info into the OpenTUI console overlay when consoleMode is console-overlay.
  • Row notices still land through surfaceSystemNotice and are not mirrored. The overlay stays hidden unless SHOW_CONSOLE is set; the file log sink stays mandatory.
  • The headless harness forwards consoleMode and clock. A kill-ring chord test drives Ctrl+U / Ctrl+Y through mock keys.

Verification

  • bun test src/tui/runtime-notices-console.test.ts src/tui/prompt-kill-ring.test.ts src/tui/runtime-notices.test.ts passes (39 tests, exit 0)
  • Pre-commit tsc --noEmit and bun build pass on both commits
  • Installed @opentui/core 0.6.4 testing.d.ts re-exports test-renderer, mock-keys, mock-mouse, mock-tree-sitter-client, terminal-capabilities, spy, ManualClock, and TestRecorder. testing/test-renderer.d.ts adds dispose and Symbol.asyncDispose; TestRendererOptions extends CliRendererConfig, so clock and consoleMode pass through. The harness still destroys via renderer.destroy().

Fixes CL-10641

@linear-code

linear-code Bot commented Oct 15, 2026

Copy link
Copy Markdown

CL-10641

@corbits-triage

corbits-triage Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by the comment below.

@corbits-triage

corbits-triage Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Triage: Fail

@TheGreatAxios, please address the following:

  • Split out unrelated change: src/tui/prompt-kill-ring.test.ts

@TheGreatAxios
TheGreatAxios changed the base branch from cl-10647-tui-staged-bump-opentuicore-0512-0517-064 to main October 15, 2026 19:58
@TheGreatAxios
TheGreatAxios merged commit 301e383 into main Oct 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant