Repository navigation
Advertise approve_worker_call on the dispatch tool surface - #1453
Closed
TheGreatAxios wants to merge 2 commits into
Closed
TheGreatAxios wants to merge 2 commits into
TheGreatAxios wants to merge 2 commits into
Conversation
The dispatch and orchestrator allow lists name the grant tool next to send_input so a parent can advertise it. send_input stays text-only.
Contributor
|
Triage: Fail @TheGreatAxios, please address the following:
|
CORE_TOOL_NAMES stopped at send_input, so the orchestrator prefix and the dispatch call gate never listed the grant tool. send_input stays text-only.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
approve_worker_callimmediately aftersend_input, so a parent advertises the only tool that grants a parked worker call.send_inputstays a text channel and does not grant.Verification
bun run typecheckandbun run buildpass (pre-commit)bun test src/agent/directors/tool-sets.test.ts src/agent/directors/dispatch/package.test.ts src/agent/prompt-sizes.test.tsis covered bybun run checkbun run checkreaches the suite: 9092 pass, 1 fail.scripts/check-dead-exports.test.ts("the checked-in floor stays tight to the live count") fails on thisorigin/maintree because the live scan is 1366 files and1240 * 1.1is 1364. The change adds no files.