Repository navigation
feat(tui): route shell shortcuts through opentui keymap - #1460
Merged
TheGreatAxios merged 5 commits intoOct 17, 2026
Merged
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Comment
Application chords, transcript kills, and the destroy unsubscribe go through @opentui/keymap 0.6.6. No behavior defect in the branch diff.
Findings
No defects. These comments narrate or misstate the code:
src/tui/shell/keymap.ts:3— "There is no second switch from key name to handler."src/tui/shell/keymap.ts:93— restatesshellKeymapListening.src/tui/keybindings.ts:6— "There is no second copy of the application chord table here."src/tui/keybindings.ts:83— sayssetAppShortcutRowsis called again from the live keymap. The only call is the import-time one inkeymap.ts.src/tui/keybindings.ts:96— says application rows are whatever the keymap registered.shellShortcutsreturns the import-timeappRowssnapshot.docs/TUI-keymap-eval.md:9— sayscreateDefaultOpenTuiKeymap(renderer)installs the parser. The shell buildsnew Keymap(guardHost(renderer))itself.
Notes
pokeShellKeymapPressis a test hook for the destroy unsubscribe. Leave it if that test still needs it.- Merge is blocked until this branch rebases cleanly onto main. Triage already failed on conflicts.
TheGreatAxios
force-pushed
the
cl-10734-adopt-opentuikeymap-for-shell-shortcuts
branch
from
October 17, 2026 00:55
0831b57 to
004ae6b
Compare
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
Application chords go through @opentui/keymap. The rebase keeps the textarea kill on a focused prompt, kills prompt text while the transcript is focused, and parks the caret with removedByDelete.
No findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@opentui/keymapcommands. OpenTUI is 0.6.6, which is the release that package tracks.Verification
bun run checkpasses (9095 tests, 0 fail)bun test ./src/tui/keybindings.test.ts ./src/tui/focus-routing.test.ts ./src/tui/prompt-kill-ring.test.ts --randomize --seed 424242passes (32 tests)Fixes CL-10734