Repository navigation
feat(tui): scroll the transcript and overlay through ScrollBox - #1461
Merged
TheGreatAxios merged 5 commits intoOct 16, 2026
Merged
TheGreatAxios merged 5 commits into
TheGreatAxios merged 5 commits into
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Not Ready
and removed
Triage: Needs Human Review
labels
Choice names, empty descriptions, and stale-row replacement still assert painted behavior. The lookup was failing only because the select is no longer a direct child of the overlay body.
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Not Ready
Triage: Needs Human Review
labels
OpenTUI re-engages bottom sticky at one row above the tail. Sticky now stays armed only while scrollTop is on the tail, so a same-height size pass leaves that detent pinned. Growth while the tail is followed still sticks. CL-10642
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Ready
Triage: Needs Human Review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
viewportCullingandscrollChildIntoView, and the overlay host shows a vertical scrollbar.scrollTopis at the bottom, not one row above it.Verification
bun test src/tui/shell.test.ts src/tui/transcript-anchor.test.ts src/tui/transcript-long-log-scroll.test.ts src/tui/overlay-overflow.test.ts src/tui/overlay-list.test.tspassed on this branch (scroll suites, including the one-detent regression).bun run typecheckstill fails on a pre-existing missingsemverimport invendor/intx-types/src/tool-packages.ts. This branch does not touch that file.Fixes CL-10642