Repository navigation
fix(tui): read kill spans from the edit buffer before native deletes - #1465
Merged
TheGreatAxios merged 3 commits intoOct 16, 2026
Merged
Conversation
Native Textarea and Input deletes still discard the removed text. Record the span with getTextRange on the cursor those deletes use, instead of diffing the prompt value after the fact.
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Needs Human Review
labels
deleteRange snaps or no-ops inside a wide cell, while a getTextRange prediction still names the overlapping grapheme. The ring stores the contiguous span the buffer actually lost, and the caret is parked where that span splices back so yank restores it. Refs CL-10644
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Ready
Triage: Needs Human Review
labels
The longest common prefix of a repeated span is the other copy, and parking the caret there yanks into the wrong hole. Prefer the span the native caret already sits on, and fall back to that prefix only when a snapped wide cell left the caret on none of them. Refs CL-10644
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Ready
Triage: Needs Human Review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
src/tui/prompt-kill-ring.test.tscovers kill-ring recording from EditBuffer.getTextRange before native deletes.Refs CL-10644