Repository navigation
refactor(tui): read zone rects from Yoga instead of stacking them - #1466
Merged
Merged
Conversation
Ordered collapse stays in the resolver: unequal flexShrink weights make this Yoga build overflow the column, and equal weights ignore COLLAPSE_ORDER. Prompt wheel forwarding uses onMouseScroll. Refs CL-10650
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Not Ready
and removed
Triage: Needs Human Review
Triage: Not Ready
labels
A wheel over the focused prompt replaces onMouseEvent, so the textarea viewport does not scroll with the transcript. Refs CL-10650
corbits-triage
Bot
added
Triage: Not Ready
and removed
Triage: Needs Human Review
labels
Prompt wheel routing stays on the transcript handler already on main. This slice only reads zone rects from Yoga. Refs CL-10650
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Not Ready
Triage: Needs Human Review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
tsc --noEmitandbun buildpassed.bun run testwas not re-run for this open.Refs CL-10650