Repository navigation
refactor(tui): rename mark and ramp glyph modules - #1468
Merged
Merged
Conversation
The glyph modules keep their names aligned with what they draw. Call sites follow the paths. Behavior is unchanged. Refs CL-10640
Wording only, so the behavior diff can stay within the file cap. The modules still poll until that change lands. Refs CL-10640
Wording only. The host still polls until the behavior change lands. Refs CL-10640
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
The host still polls every 200ms. Timeline and feed-append wording does not belong on a rename that leaves that poll in place. Refs CL-10640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mark-animbecomesmark-rasterandrampbecomesramp-glyphs, plus the import paths required to compile.Refs CL-10640