[TheGreatAxios]

Logs a single debug line when a pricing refresh fails and keeps the stale cache.

Part of CL-10759

[linear-code]

CL-10759

[corbits-triage]

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

[TheGreatAxios]

Review · Request changes

Five nits in one diff: pricing debug log, OTEL env note, knip evals glob, ephemeral-nudge trim, and an isomorphic-git version comment. Triage already failed this for mixing unrelated changes.

Findings

• src/session/optimized-context-store.ts:1921 — the comment now says array remove arrived in isomorphic-git 1.44.2. Upstream v1.43.0 is the release that accepted an array of filepaths. 1.44.2 is only what bun.lock installs. This replaces a correct floor with a wrong one.
• src/agent/director-core.ts:32 — text.trim() drops the leading newlines on every open-task, declined, and workflow-stall nudge. Nothing asserts that text. The comment’s cached-literal claim does not match the cache breakpoint, which sits before ephemeral turns.

Notes

• docs/PERFTRACE.md:77 restates the resourceAttributes bullet above it, and otel-config.ts:299 says it again.
• The pricing debug line and its test are fine. The knip evals glob is a separate change.

[TheGreatAxios]

Review · Request changes

Five nits in one diff: pricing debug log, OTEL env note, knip evals glob, ephemeral-nudge trim, and an isomorphic-git version comment. Triage already failed this for mixing unrelated changes.

Findings

• src/session/optimized-context-store.ts:1921 — the comment now says array remove arrived in isomorphic-git 1.44.2. Upstream v1.43.0 is the release that accepted an array of filepaths. 1.44.2 is only what bun.lock installs. This replaces a correct floor with a wrong one.
• src/agent/director-core.ts:32 — text.trim() drops the leading newlines on every open-task, declined, and workflow-stall nudge. Nothing asserts that text. The comment’s cached-literal claim does not match the cache breakpoint, which sits before ephemeral turns.

Notes

• docs/PERFTRACE.md:77 restates the resourceAttributes bullet above it, and otel-config.ts:299 says it again.
• The pricing debug line and its test are fine. The knip evals glob is a separate change.

[TheGreatAxios]

Review · Approve

A failed pricing refresh logs once and still returns the cache. The diff is only that log and its test.

No findings.