[TheGreatAxios]

Summary

• Correct the ProviderSettings temperature/topP comment to state the exclusion is enforced at settings load, while provider adapters may still send both when mandated by model-card defaults.
• Pin the behavior with tests covering load rejection of both knobs and wire passthrough of provider-mandated pairs.

Verification

• Config suite: 267 pass; settings suite: 168 pass
• Lint clean

Fixes CL-10760

[linear-code]

CL-10760

[corbits-triage]

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

[TheGreatAxios]

Review · Comment

Settings load still rejects temperature and topP together. DeepSeek V4 backfills both on the wire when the fields are absent. One docs-and-tests change.

Findings

• src/config.test.ts:1471 — the new comment says buildOpenAISource merging both is why DeepSeek V4 defaults reach the wire. The adapter applies those defaults later, when the fields are absent. The assertion is right; the cause is not.

Notes

• CL-10760 is in the new comments and the test name. Drop the ticket tag.

[TheGreatAxios]

Review · Approve

Settings load rejects temperature and topP together. DeepSeek V4 writes both defaults only when the body fields are absent. The test comment now says that.

No findings.