Repository navigation
docs(permissions): clarify project-layer scope and log canonical grant-file path - #1474
Merged
Merged
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Comment
--permissions still leaves session and project grants in place, and a successful load logs the realpath plus the approval count. One change. The tests match the loader.
Findings
src/permission/store.ts:344— the comment says those calls produce one log line for the process lifetime.loadConfig, seed, and/permissionslist each callloadPermissionsFile, so each load logs.docs/IMPLEMENTATION.md:440— the flag table only says the file replaces user-global and provider-model grants.CLI_HELP_TEXTalso says session and project grants still apply, and project entries still need trust confirmation. The same doc says that table stays in sync with help.
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
--permissions still leaves session and project grants in place, and every grant-file load logs the realpath and the approval count. The help table matches that.
No findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to CL-10749: documents that
--permissionsreplaces only the global + provider-model grant layers (session + project layers still apply; project entries still need trust confirmation), and logs the canonical realpath grant-file target with approval count on every load (startup validation, seed, /permissions reseed).Verification
bun run checkgate: greenFixes CL-10754