Skip to content

docs(permissions): clarify project-layer scope and log canonical grant-file path - #1474

Merged
TheGreatAxios merged 3 commits into
mainfrom
cl-10754-permissions-file-followups
Oct 17, 2026
Merged

TheGreatAxios merged 3 commits into
mainfrom
cl-10754-permissions-file-followups

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to CL-10749: documents that --permissions replaces only the global + provider-model grant layers (session + project layers still apply; project entries still need trust confirmation), and logs the canonical realpath grant-file target with approval count on every load (startup validation, seed, /permissions reseed).

Verification

  • New src/permission/permissions-file.test.ts: 4 pass
  • Full related suite: 1475 pass
  • Full bun run check gate: green

Fixes CL-10754

@linear-code

linear-code Bot commented Oct 17, 2026

Copy link
Copy Markdown

CL-10754

@corbits-triage

corbits-triage Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review · Comment

--permissions still leaves session and project grants in place, and a successful load logs the realpath plus the approval count. One change. The tests match the loader.

Findings

  • src/permission/store.ts:344 — the comment says those calls produce one log line for the process lifetime. loadConfig, seed, and /permissions list each call loadPermissionsFile, so each load logs.
  • docs/IMPLEMENTATION.md:440 — the flag table only says the file replaces user-global and provider-model grants. CLI_HELP_TEXT also says session and project grants still apply, and project entries still need trust confirmation. The same doc says that table stays in sync with help.

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review · Approve

--permissions still leaves session and project grants in place, and every grant-file load logs the realpath and the approval count. The help table matches that.

No findings.

@TheGreatAxios
TheGreatAxios merged commit 8a95baa into main Oct 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant