Repository navigation
fix(config): restore --no-workflow as warn-and-ignore shim - #1475
Merged
Merged
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Needs Human Review
labels
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Comment
--no-workflow warns and is ignored. It does not change Config. One change.
Findings
docs/IMPLEMENTATION.md:425— the help table lists--no-workflow, and the table is supposed to matchCLI_HELP_TEXT.src/config/index.ts:717does not print that flag.src/config/settings.test.ts:208— the test checks stderr andconfigured === true. It still passes if the flag swallows the task token. Asserttask,command, andautoagainst the same argv without the flag.
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Not Ready
and removed
Triage: Ready
Triage: Needs Human Review
labels
TheGreatAxios
force-pushed
the
cl-10755-no-workflow-shim
branch
from
October 17, 2026 01:44
f009f1e to
f080943
Compare
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Not Ready
Triage: Needs Human Review
labels
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
--no-workflow warns and is ignored. Help lists it, and the test fails if the flag swallows the task.
No findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-workflowis accepted again as a deprecated no-op that writes a stderr warning and is ignored, so existing wrappers keep starting instead of hitting the catch-all unrecognized-flag errorVerification
bun test src/config/ src/config.test.ts: 322 passFixes CL-10755